feat(lastcode): prove hosted CI waiting - #104
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8916428a36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Briefly closing and reopening to trigger the newly enabled hosted-CI proof without changing the reviewed head. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
0da5604 to
bf1fa30
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
The existing waiter assumes that every PR must eventually report a hosted check, so repositories with CI disabled can wait forever. Before GitHub CI can become authoritative, we also need one stable aggregate gate tied to the exact synthesized PR merge revision.
This change moves the existing workflow onto standard GitHub runners, adds a fail-closed
CI Gate, and teachesWait for PRto distinguish disabled/non-required CI from an enabled workflow that has not registered yet. The waiter binds local branch, worktree, PR, head, base, merge revision, workflow run, and aggregate job identity; it wakes on actionable failures or bounded missing-registration states while keeping clean review completion asleep until all passive gates are ready.Focused validation: 41 tests across the workflow policy, GitHub-CI evaluator, and waiter; scripts-package typecheck; focused lint; YAML parse; diff check. The branch was published with
--no-verifyto avoid the known blocking Quick CI hook; the existing Full CI stamp remains required for guarded merge during this proof slice.Part of #103.
Implemented with GPT-5.6 Sol in the Codex harness.